Sessions - view all changes action uses the diff editor + navigation tree

[lszomoru]

No description provided.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@jrieken

Matched files:

• src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts

[Copilot]

Pull request overview

This PR refactors how the “View All Changes” command is wired up in the Sessions window by relocating the action registration into the Sessions Changes view contribution and exposing a ChangesViewPane.openChanges() helper that opens the first changed file with modal diff navigation.

Changes:

• Remove ViewAllSessionChangesAction from the workbench chat editing actions and stop treating it specially in the chat input toolbar button configuration.
• Add a Sessions-scoped ViewAllSessionChangesAction that calls into the Sessions Changes view (ChangesViewPane.openChanges()).
• Refactor file opening logic in ChangesViewPane into a reusable _openFileItem(...) helper and add openChanges().

Show a summary per file

File	Description
src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts	Removes the “View All Changes” action import and its icon-only button configuration in the chat input button bar.
src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingActions.ts	Deletes the old ViewAllSessionChangesAction implementation and related imports.
src/vs/sessions/contrib/changes/browser/changesViewActions.ts	Introduces a Sessions Changes-view action (chatEditing.viewAllSessionChanges) that triggers ChangesViewPane.openChanges().
src/vs/sessions/contrib/changes/browser/changesView.ts	Adds openChanges() and extracts _openFileItem(...) from the inline tree handler.

Copilot's findings

Comments suppressed due to low confidence (2)

src/vs/sessions/contrib/changes/browser/changesView.ts:909

• openChanges() awaits _openFileItem(...), but _openFileItem currently doesn't await editorService.openEditor(...), so openChanges() resolves before the editor is actually opened. Either await the openEditor call(s) inside _openFileItem (and keep the async contract) or make both methods synchronous to avoid misleading await usage.

	async openChanges(): Promise<void> {
		const items = this.viewModel.activeSessionChangesObs.get();
		if (items.length === 0) {
			return;
		}

		const changes = toIChangesFileItem(items);
		await this._openFileItem(changes[0], changes, false, false, false, changes.length > 1);
	}

src/vs/sessions/contrib/changes/browser/changesView.ts:919

• Avoid creating a new bound function on every open: this._openFileItem.bind(this) allocates and is only used to capture this. Prefer an inline arrow wrapper when passing callbacks (and consider void-ing the returned promise if _openFileItem remains async).

		const sidebar = includeSidebar ? {
			render: (container: unknown, onDidLayout: Event<{ readonly height: number; readonly width: number }>) => {
				return this.renderSidebarList(container as HTMLElement, onDidLayout, items, this._openFileItem.bind(this));
			}
		} : undefined;

• Files reviewed: 4/4 changed files
• Comments generated: 3