Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes “internal skill” handling (previously identified via the vscode-chat-internal URI scheme) from the Copilot custom-instructions/skills pipeline, keeping only configured/workspace/personal/extension-contributed skill locations.
Changes:
- Removes
vscode-chat-internalrecognition from external-instructions file checks. - Removes internal-scheme skill resolution (
getChatInternalSkillInfo) from skill identification and metadata helpers. - Deletes the unit test that asserted
SkillStorage.Internalbehavior forvscode-chat-internalURIs.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/customInstructions/common/customInstructionsService.ts | Removes internal-scheme skill detection and ensures skill helpers only consult configured/known skill locations. |
| extensions/copilot/src/extension/tools/node/toolUtils.ts | Stops treating vscode-chat-internal URIs as automatically-allowed “external instructions” files for tool access checks. |
| extensions/copilot/src/extension/tools/node/test/readFile.spec.tsx | Removes the test case validating telemetry skillStorage=internal for vscode-chat-internal skill reads. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
hediet
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.