ci: bump github runner to ubuntu-24.04 to address fontconfig crash #308495
Merged
deepak1556 merged 4 commits intomainfrom Apr 8, 2026
Merged
ci: bump github runner to ubuntu-24.04 to address fontconfig crash #308495deepak1556 merged 4 commits intomainfrom
deepak1556 merged 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a diagnostic step to the Linux PR test workflow to help investigate a suspected fontconfig-related crash during app launch in CI.
Changes:
- Print installed font-related package versions and installed font packages.
- Validate
/etc/fonts/fonts.confand/etc/fonts/conf.d/*.confwithxmllint. - Attempt to clear and rebuild fontconfig caches and print the fontconfig version.
Collaborator
Author
|
libexpat is on v2.4.7, very likely related to libexpat/libexpat@e5d6bf0 which is only fixed from v2.6.3 Never mind, the version carries the patches https://launchpadlibrarian.net/846116146/expat_2.4.7-1ubuntu0.6_2.4.7-1ubuntu0.7.diff.gz |
Fixes an intermittent SIGSEGV on the [pango] FcInit thread during Electron startup in CI integration tests. Root cause: Chromium's InitializeGlobalFontConfigAsync() posts FcInit() to a thread pool worker (crbug.com/404311), while pango's pangoft2 backend independently calls FcInit() from its own thread during GTK initialization. fontconfig 2.13.1 (shipped in ubuntu-22.04) lacks thread-safe initialization — concurrent first-time FcInit() calls race and both enter FcConfigParse(), corrupting shared global state. This causes expat (called by fontconfig to parse fonts.conf) to dereference a NULL pointer. ubuntu-24.04 ships fontconfig 2.15.0 which includes the thread-safe initialization from 2.14+.
deepak1556
changed the title
deepak1556
changed the title
deepak1556
requested review from
TylerLeonhardt,
joaomoreno,
lszomoru and
rzhao271
as code owners
lszomoru
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode/actions/runs/24122759225/job/70380360453?pr=293913
Root cause: Chromium's
InitializeGlobalFontConfigAsyncpostsFcInitto a thread pool worker (crbug.com/404311), while pango's pangoft2 backend independently callsFcInitfrom its own thread during GTKinitialization. Fontconfig 2.13.1 (shipped in ubuntu-22.04) lacks thread-safe initialization — concurrent first-time
FcInitcalls race and both enterFcConfigParse, corrupting shared global state. This causes expat (called by fontconfig to parse fonts.conf) to dereference a NULL pointer.ubuntu-24.04 ships fontconfig 2.15.0 which includes the thread-safe initialization from 2.14+.