Skip to content

nes: add tests for cursor jump and recursion#308499

Merged
ulugbekna merged 2 commits intomainfrom
ulugbekna/xtab-response-splitup
Apr 8, 2026
Merged

nes: add tests for cursor jump and recursion#308499
ulugbekna merged 2 commits intomainfrom
ulugbekna/xtab-response-splitup

Conversation

@ulugbekna
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 13:03
@ulugbekna ulugbekna enabled auto-merge (squash) April 8, 2026 13:03
@ulugbekna ulugbekna self-assigned this Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds additional integration test coverage for XtabProvider’s next-edit retry behavior, focusing on cursor-jump retries and model-fallback recursion guards.

Changes:

  • Adds tests verifying cursor-jump retry yields edits marked isFromCursorJump and includes originalWindow.
  • Adds a regression test ensuring cursor-jump retry does not recurse into a second retry when the retry also yields no edits.
  • Adds tests for model fallback on NotFound, including successful retry and a “no edits” retry that must not loop.
Show a summary per file
File Description
extensions/copilot/src/extension/xtab/test/node/xtabProvider.spec.ts Adds new cursor-jump retry and model-fallback recursion tests for XtabProvider.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread extensions/copilot/src/extension/xtab/test/node/xtabProvider.spec.ts Outdated
alexdima
alexdima previously approved these changes Apr 8, 2026
@ulugbekna ulugbekna merged commit 98f1161 into main Apr 8, 2026
23 checks passed
@ulugbekna ulugbekna deleted the ulugbekna/xtab-response-splitup branch April 8, 2026 13:37
@vs-code-engineering vs-code-engineering bot added this to the 1.116.0 milestone Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants