Skip to content

Sessions - fix changes view when initializing a repository#308513

Merged
lszomoru merged 1 commit intomainfrom
lszomoru/satisfactory-crayfish
Apr 8, 2026
Merged

Sessions - fix changes view when initializing a repository#308513
lszomoru merged 1 commit intomainfrom
lszomoru/satisfactory-crayfish

Conversation

@lszomoru
Copy link
Copy Markdown
Member

@lszomoru lszomoru commented Apr 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 8, 2026 14:05
@lszomoru lszomoru enabled auto-merge (squash) April 8, 2026 14:05
@lszomoru lszomoru self-assigned this Apr 8, 2026
@lszomoru lszomoru added this to the 1.116.0 milestone Apr 8, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix the Sessions “Changes” view failing to resolve/open the correct git repository immediately after a repository is initialized, by persisting repository info to session metadata and using that metadata when opening the repo in the Sessions window.

Changes:

  • Prefer session.metadata.repositoryPath when resolving the working directory for gitService.openRepository(...) in the Sessions Changes view model.
  • Ensure repository initialization persists workspace/repo metadata in order by awaiting trackSessionWorkspaceFolder(...).
  • Refactor CLI sessions initialization to build RepositoryProperties explicitly (and use satisfies for type checking).
Show a summary per file
File Description
src/vs/sessions/contrib/changes/browser/changesViewModel.ts Uses session metadata (repositoryPath) to resolve the repository location when opening the git repo for the Changes view.
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts Awaits workspace-folder tracking after git init so session metadata is reliably written before follow-up actions.
extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts Refactors and awaits repository/workspace tracking after git init and refreshes the session content.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread src/vs/sessions/contrib/changes/browser/changesViewModel.ts
@lszomoru lszomoru merged commit 7f5c298 into main Apr 8, 2026
27 checks passed
@lszomoru lszomoru deleted the lszomoru/satisfactory-crayfish branch April 8, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants