mark auto updatable built in extensions as application scoped always#308522
Merged
mark auto updatable built in extensions as application scoped always#308522
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the extensions user-data-sync payload generation so that built-in extensions configured for out-of-band auto-updates (via productService.builtInExtensionsEnabledWithAutoUpdates) are always treated as application-scoped when computing local sync extensions.
Changes:
- Inject
IProductServiceintoLocalExtensionsProvider. - Mark extensions listed in
builtInExtensionsEnabledWithAutoUpdatesasisApplicationScoped: truein the local sync model. - Fix a local variable typo (
syncExntesion→syncExtension) in the mapping logic.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/userDataSync/common/extensionsSync.ts |
Uses product configuration to force application-scope for auto-updatable built-in extensions when building local sync extensions. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Comment on lines
+387
to
+388
| if (this.productService.builtInExtensionsEnabledWithAutoUpdates?.some(id => id.toLowerCase() === identifier.id.toLowerCase())) { | ||
| syncExtension.isApplicationScoped = true; |
There was a problem hiding this comment.
The builtInExtensionsEnabledWithAutoUpdates?.some(id => id.toLowerCase() === identifier.id.toLowerCase()) check runs inside the per-extension mapping and lowercases strings repeatedly. Consider precomputing a lowercased Set of these IDs once in the LocalExtensionsProvider constructor (or a helper) and then doing a single has() lookup to reduce per-sync work and allocations.
aeschli
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.