Sessions - fix hasGitHubRemote state detection#308677
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes GitHub-remote detection in the Sessions Changes view model by avoiding a non-null assertion on repository state, preventing incorrect state evaluation (and potential runtime errors) when the repository state is not yet available.
Changes:
- Guard
hasGitHubRemotes(...)behind arepositoryStatepresence check and default tofalsewhen undefined.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/changesViewModel.ts | Avoids calling hasGitHubRemotes with an undefined repository state when computing pull-request-related session state. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
joaomoreno
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.