Sessions - fix title menu context when switching between views#308781
Merged
Sessions - fix title menu context when switching between views#308781
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts how the Sessions “Changes” view updates its view-title toolbar/menu context so that the correct actions/context are shown after switching between views in the sessions window.
Changes:
- Moves the reactive
updateActions()trigger from the constructor to the view’s visibility-driven render lifecycle (onVisible()). - Scopes the title-action autorun to
renderDisposablesso it is cleared when the body is hidden.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/changes/browser/changesView.ts | Changes when/how the view-title toolbar context/actions are refreshed based on active session resource changes. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
alexr00
approved these changes
Apr 9, 2026
joshspicer
pushed a commit
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.