feat: apply selected option values to active chat sessions on update#308931
Merged
DonJayamanne merged 1 commit intomainfrom Apr 10, 2026
Merged
feat: apply selected option values to active chat sessions on update#308931DonJayamanne merged 1 commit intomainfrom
DonJayamanne merged 1 commit intomainfrom
Conversation
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/FailedWithoutDuration/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadgeAndDiff/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithBadgeAndDiff/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the workbench chat sessions option-group handling so that when providers refresh option groups, selected values are propagated into already-active sessions (keeping session option caches in sync with the latest provider state).
Changes:
- Apply option-group
selectedvalues to active sessions of the same session type when option groups are updated. - Avoid firing
onDidChangeSessionOptionsduring this sync to prevent extension-host feedback loops.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/chatSessions/chatSessions.contribution.ts |
Propagates updated option-group selections into active session option caches during setOptionGroupsForSessionType. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 2
rebornix
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #288457 (comment)
Initializing selected property after handling onDidChange doesn't work, I can see the items in the dropdown have change, however the selected value in the UI is still the old value @mjbvz @DonJayamanne
This is a blocker in multi-root workspace or empty workspace