Skip to content

nes: show thumbsdown icon for previously rejected NES in log tree#309408

Merged
ulugbekna merged 2 commits intomainfrom
ulugbekna/blank-pony
Apr 13, 2026
Merged

nes: show thumbsdown icon for previously rejected NES in log tree#309408
ulugbekna merged 2 commits intomainfrom
ulugbekna/blank-pony

Conversation

@ulugbekna
Copy link
Copy Markdown
Contributor

Previously rejected NES entries now show a 👎 icon instead of no specific icon. Uses direct outcome assignment to avoid false warnings on the succeeded→previouslyRejected transition. Also registers the rebasedEdit (when present) with the rejection collector.

Previously rejected NES entries now show a 👎 icon instead of no
specific icon. Uses direct outcome assignment to avoid false warnings
on the succeeded→previouslyRejected transition. Also registers
the rebasedEdit (when present) with the rejection collector.
Copilot AI review requested due to automatic review settings April 13, 2026 09:04
@ulugbekna ulugbekna self-assigned this Apr 13, 2026
@ulugbekna ulugbekna enabled auto-merge (squash) April 13, 2026 09:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Copilot inline edits (NES) logging UI to clearly indicate when a suggestion was previously rejected, by introducing a dedicated log outcome and icon and wiring it up from the provider logic.

Changes:

  • Added a thumbs-down icon and mapped a new previouslyRejected log outcome to it.
  • Introduced markAsPreviouslyRejected() on InlineEditRequestLogContext to set the new outcome without triggering outcome-transition warnings.
  • Updated NextEditProvider to mark log contexts as previously rejected and to reject rebasedEdit when present.
Show a summary per file
File Description
extensions/copilot/src/platform/inlineEdits/common/utils/utils.ts Adds a new thumbs-down icon definition for log rendering.
extensions/copilot/src/platform/inlineEdits/common/inlineEditLogContext.ts Adds previouslyRejected outcome, icon mapping, and a setter method to apply it.
extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts Marks relevant flows as previously rejected and ensures rebased edits are collected for rejection.

Copilot's findings

Comments suppressed due to low confidence (1)

extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts:340

  • New behavior is introduced for the “previously rejected” paths (setting a distinct log outcome and rejecting rebasedEdit when present), but there doesn’t appear to be test coverage validating it. Please add/extend NextEditProvider tests to cover: (1) a cached edit marked rejected results in the log context being marked previously rejected, and (2) when a cached rejected edit has rebasedEdit, that exact edit is passed to RejectionCollector.reject.
		const cachedEdit = this._nextEditCache.lookupNextEdit(docId, documentAtInvocationTime, selections);
		if (cachedEdit?.rejected) {
			logger.trace('cached edit was previously rejected');
			telemetryBuilder.setStatus('previouslyRejectedCache');
			telemetryBuilder.setWasPreviouslyRejected();
			logContext.markAsPreviouslyRejected();
			const rejectedEdit = cachedEdit.rebasedEdit ?? cachedEdit.edit;
			if (rejectedEdit) {
				this._rejectionCollector.reject(docId, rejectedEdit);
			}
  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread extensions/copilot/src/platform/inlineEdits/common/utils/utils.ts
…ogContext.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ulugbekna ulugbekna merged commit 8210900 into main Apr 13, 2026
40 of 41 checks passed
@ulugbekna ulugbekna deleted the ulugbekna/blank-pony branch April 13, 2026 11:37
@vs-code-engineering vs-code-engineering Bot added this to the 1.117.0 milestone Apr 13, 2026
@ulugbekna ulugbekna added the ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch label Apr 13, 2026
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants