Fix sandbox terminal command display

[dileepyavan]

Summary

Fixes #309430

This prevents internal sandbox wrapper commands from leaking into the chat view for terminal tool invocations while running background.

The terminal command pipeline can apply multiple command-line rewrites. The sandbox rewriter correctly sets a clean forDisplay command while storing the wrapped command in toolEdited for execution. However, later execution-only rewrites, such as background detach wrapping, could replace forDisplay with a command that already included sandbox details. The chat UI then used that overwritten display command and showed the sandbox wrapper to the user.

This change makes the first explicit forDisplay value sticky during command rewriting:

• execution continues to use the fully rewritten command via toolEdited
• chat display continues to use the clean user-facing command via forDisplay
• sandboxed invocations still show the sandbox label/icon without exposing the wrapper implementation

Testing

• npm run transpile-client
• ./scripts/test.sh --run src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts

Added regression coverage for a sandboxed async command with background detach enabled, verifying that chat displays echo hello while the executed command remains nohup sandbox-runtime echo hello &.

[github-actions]

Screenshot Changes

Base: 985aca65 Current: 865ded41

Changed (1)

agentSessionsViewer/NeedsInput/Light

Before	After

[Copilot]

Pull request overview

Fixes a terminal chat UX issue where internal sandbox wrapper commands could appear in the chat invocation text when additional execution-only command rewrites (eg. background detach) run after sandbox wrapping.

Changes:

• Make the first forDisplay value produced during command rewriting “sticky” so later rewriters can’t overwrite it.
• Add a regression test covering a sandboxed async command with background detach enabled, ensuring chat displays the clean command while execution uses the fully wrapped command.

Show a summary per file

File	Description
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts	Adjusts command rewrite aggregation so forDisplayCommand is only set once (first non-undefined).
src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts	Adds regression coverage ensuring sandbox wrapper details don’t leak into chat display for detached async commands.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 0