Prevent enable si showing up when using pwsh from chat with accessibility mode#309606
Merged
anthonykim1 merged 8 commits intomainfrom Apr 15, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts RunInTerminalTool’s “Enable shell integration” guidance so it doesn’t appear when shell integration is already enabled via settings, addressing the misleading warning seen in accessibility/screen reader scenarios.
Changes:
- Import
TerminalSettingIdto read the shell integration enablement setting. - Gate the “Enable shell integration…” info message on both
shellIntegrationQuality === Noneandterminal.integrated.shellIntegration.enabled !== true.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts |
Suppresses the “Enable shell integration…” prompt when shell integration is already enabled in configuration. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Changed (1)blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark

#### editor/codeEditor/CodeEditor/Light
 |
Contributor
Author
@meganrogge was right, powershell 7 did not show the `enable shell integration warning` whereas windows powershell did.
|
anthonykim1
commented
Apr 15, 2026
| commandDetection!, | ||
| executionOptions.persistentSession | ||
| ); | ||
| if (toolTerminal.shellIntegrationQuality === ShellIntegrationQuality.None) { |
Contributor
Author
There was a problem hiding this comment.
The shell integration banner decision is deferred to after command execution completes (see below). This gives SI time to arrive — on Windows PowerShell 5.1, cold-loading PSReadLine can push HasRichCommandDetection past the initial wait timeout, and checking here would incorrectly show the banner.
Yoyokrazy
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves: #307698
Before:

After:
afterEnableFix.mp4
Two parts to this:
enable shell integrationmessage again