Revert bad model picker changes

[roblourens]

From #309331

Co-authored-by: Copilot copilot@github.com

[github-actions]

Screenshot Changes

Base: 083e1db4 Current: 6b9d45e4

Changed (4)

chat/aiCustomizations/aiCustomizationManagementEditor/PromptsTabScrolled/Dark

Before	After

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light

Before	After

editor/inlineCompletions/other/JumpToHint/Dark

Before	After

agentSessionsViewer/NeedsInput/Light

Before	After

[Copilot]

Pull request overview

Reverts the “model picker owns model state via sessions/providers” approach from #309331 by reintroducing local persistence for the sessions window model picker and pushing that selection into the active session/provider.

Changes:

• Add IStorageService usage to persist the local model picker’s selected model id.
• Initialize the picker from stored state (or first available model) and push selection into the active session/provider.
• Refactor getAvailableModels to read the active session from ISessionsManagementService.

Show a summary per file

File	Description
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsActions.ts	Reintroduces local model selection persistence for the sessions window model picker and updates how selection is initialized/applied.

Copilot's findings

Comments suppressed due to low confidence (1)

src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsActions.ts:264

• The autorun reads currentModel, so it will fire on both session changes and model changes. Since delegate.setModel already calls provider.setModel(...), this can result in duplicate setModel calls (and for some providers, duplicate dispatch/network work). Consider making this reaction depend only on activeSession changes (e.g., avoid tracking currentModel here) or dedupe by tracking the last (sessionId, modelId) pushed.

				// When the active session changes, push the selected model to the new session
				disposableStore.add(autorun(reader => {
					const session = sessionsManagementService.activeSession.read(reader);
					const model = currentModel.read(reader);
					if (session && model) {
						const provider = sessionsProvidersService.getProviders().find(p => p.id === session.providerId);
						provider?.setModel(session.sessionId, model.identifier);
					}

• Files reviewed: 1/1 changed files
• Comments generated: 1