Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR moves “session readiness” (whether the active session can accept/send requests) onto the ISession model as an observable, so UI components don’t need to query agent-host providers directly for config readiness.
Changes:
- Add
ISession.ready: IObservable<boolean>to the sessions model. - Plumb
readythrough session providers (local agent host, remote agent host, Copilot sessions) and test session factories. - Update the “new chat” welcome UI to enable/disable Send based on
activeSession.readyinstead of provider config watchers.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/services/sessions/common/session.ts | Adds ready observable to ISession. |
| src/vs/sessions/contrib/chat/browser/newChatViewPane.ts | Switches Send button enablement logic to use activeSession.ready. |
| src/vs/sessions/contrib/localAgentHost/browser/localAgentHostSessionsProvider.ts | Adds and updates a ready observable for local agent-host sessions based on session config readiness. |
| src/vs/sessions/contrib/remoteAgentHost/browser/remoteAgentHostSessionsProvider.ts | Adds and updates a ready observable for remote agent-host sessions based on session config readiness. |
| src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts | Sets ready to always-true for Copilot chat sessions. |
| src/vs/sessions/contrib/chat/test/browser/sessionsConfigurationService.test.ts | Updates test session factory to include ready. |
| src/vs/sessions/contrib/terminal/test/browser/sessionsTerminalContribution.test.ts | Updates test session factories to include ready. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsListModelService.test.ts | Updates test session factory to include ready. |
| src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts | Updates test session factory to include ready. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 1
lszomoru
approved these changes
Apr 14, 2026
chrmarti
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.