feat(macOS): enable cross app update#309812
Merged
deepak1556 merged 5 commits intomainfrom Apr 15, 2026
Merged
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
Enables macOS cross-app update coordination for the Agents app (mirroring existing Windows behavior) by introducing a shared cross-app IPC service and refactoring existing crossAppIPC consumers to use it.
Changes:
- Enable cross-app update coordinator on macOS (insider/exploration) in the Agents UI and app bootstrap.
- Introduce
ICrossAppIPCServiceto own a singlecrossAppIPCconnection and expose connect/disconnect/message events. - Refactor
CrossAppUpdateCoordinatorandMacOSCrossAppSecretSharingto consumeICrossAppIPCServiceinstead of creating their own connections.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/accountMenu/browser/account.contribution.ts | Treat macOS insider/exploration as having cross-app update coordination available. |
| src/vs/platform/update/electron-main/crossAppUpdateIpc.ts | Update coordinator now uses shared IPC service instead of owning Electron crossAppIPC directly. |
| src/vs/platform/secrets/electron-main/macOSCrossAppSecretSharing.ts | Secret sharing refactored to use shared IPC service. |
| src/vs/platform/crossAppIpc/electron-main/crossAppIpcService.ts | New shared service that manages the single crossAppIPC connection and events. |
| src/vs/code/electron-main/app.ts | Registers the service and initializes it for cross-app update coordination on macOS/Windows insider/exploration. |
| package.json | Updates distro identifier. |
| build/lib/electron.ts | Alters Electron build tag logic (now hard-coded). |
Comments suppressed due to low confidence (1)
src/vs/platform/secrets/electron-main/macOSCrossAppSecretSharing.ts:176
initializeAsHostAppcheckscrossAppIPCService.available, butavailableis currently false unlessCrossAppIPCService.initialize()has already been called somewhere else. This makes host-side secret sharing a no-op when the update coordinator path doesn’t run (e.g. non-insider/exploration). Ensure the IPC service is initialized before checking availability / registering message handlers so the host can actually respond toSecretRequest.
if (!this.crossAppIPCService.available) {
this.logService.info('[CrossAppSecretSharing] crossAppIPC not available');
onComplete?.();
return;
}
e983f77 to
fdb49b9
Compare
ICrossAppIPCService: - Owns the single crossAppIPC connection for the application - Exposes onDidConnect, onDidDisconnect, onDidReceiveMessage events Secret sharing refactoring: - MacOSCrossAppSecretSharing now takes ICrossAppIPCService instead of creating its own crossAppIPC connection
58ca902 to
2b7108d
Compare
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
@TylerLeonhardtMatched files:
|
lszomoru
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #308646