allow user to configure default permission mode#309966
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new chat setting to let users choose the default tool-permission mode for new chat sessions, while respecting enterprise policy that can disable auto-approval.
Changes:
- Introduces
chat.permissions.defaultconfiguration and surfaces it in the configuration registry. - Initializes and resets the chat permission picker based on the new setting for new/empty sessions.
- Adds validation + policy clamping to ensure invalid values or policy-disabled modes fall back to “Default Approvals”.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/constants.ts | Adds the new config key and a runtime type-guard for validating permission-level strings. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Reads the new setting to initialize/reset permission level and clamps it when policy disables auto-approval. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Registers the new user-facing setting with enum options, labels, and descriptions. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 6
Contributor
Screenshot ChangesBase: Changed (6)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationListWidget/InstructionsTabWithItems/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Dark
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/HooksTab/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
Yoyokrazy
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #309562