Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes stale rendering when applying edits by ensuring replaced pinned markdown edit pills are fully removed from the thinking container’s bookkeeping and DOM.
Changes:
- Add
removeEditPillByPartIdto clean up thinking-part internal state for replaced markdown edit pills. - Call the cleanup from
ChatListItemRendererbefore replacing a pinned markdown part, and remove the old DOM node. - Add a browser test asserting aggregated diff stats update after removing an edit pill.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatThinkingContentPart.test.ts | Adds coverage for removing an edit pill and updating aggregated diff stats. |
| src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts | Cleans up thinking-part state before replacing pinned markdown parts; removes old DOM node after replacement. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts | Introduces removeEditPillByPartId to remove stale bookkeeping for replaced edit pills. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 3
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
| Before | After |
|---|---|
 |
 |
Yoyokrazy
approved these changes
Apr 14, 2026
bryanchen-d
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue where this was happening for edits:
