Conversation
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Light
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Reverts the earlier change that propagated user-edited terminal commands through the ConfirmTerminalCommandTool result, restoring the prior “simple confirmation” behavior for the two-step terminal confirmation flow.
Changes:
- Simplifies
ConfirmTerminalCommandTool.invoke()to return a basic'yes'confirmation result. - Removes tests that asserted the tool returns edited-command messaging and tags.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts | Removes ConfirmTerminalCommandTool.invoke() behavior assertions that depended on propagating edited commands. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalConfirmationTool.ts | Reverts edited-command handling; makes the confirmation tool return a minimal 'yes' result. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
lszomoru
approved these changes
Apr 16, 2026
bpasero
deleted the
revert-309908-copilot/fix-terminal-command-ignores-edits
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #309908