feat: support launching agents/vscode app without protocol handler#310773
Merged
deepak1556 merged 1 commit intomainfrom Apr 16, 2026
Merged
feat: support launching agents/vscode app without protocol handler#310773deepak1556 merged 1 commit intomainfrom
deepak1556 merged 1 commit intomainfrom
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a native “launch sibling app” pathway (host ↔ embedded) so Agents/VS Code can be launched without relying on OS protocol handler registration, improving robustness for packaged/enterprise scenarios.
Changes:
- Add
INativeHostService.launchSiblingApp()and implement it in the Electron main process using a newplatform/native/node/siblingApp.tshelper. - Switch “Open Agents Application” to launch the sibling app directly on macOS/Windows (built builds).
- Add a Sessions desktop contribution to “Open in VS Code” by launching the host app with CLI args, and extend product/build metadata to support sibling bundle IDs.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/electron-browser/workbenchTestServices.ts | Adds a test stub for the new native host API. |
| src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts | Uses native sibling-app launch instead of protocol opener in built desktop scenarios. |
| src/vs/sessions/sessions.desktop.main.ts | Registers a desktop-specific “Open in VS Code” override contribution. |
| src/vs/sessions/contrib/chat/electron-browser/openInVSCode.contribution.ts | Implements desktop override that launches the host app with --folder-uri and --open-url. |
| src/vs/platform/native/node/siblingApp.ts | New helper to resolve & spawn the sibling application per-platform. |
| src/vs/platform/native/electron-main/nativeHostMainService.ts | Wires the new method through the main-process native host service. |
| src/vs/platform/native/common/native.ts | Extends native host interface with launchSiblingApp. |
| src/vs/code/node/cli.ts | Reuses sibling resolution logic for --agents on Windows; simplifies macOS embedded launch to open -b. |
| src/vs/base/common/product.ts | Adds darwinSiblingBundleIdentifier to product configuration types. |
| build/lib/embeddedType.ts | Extends embedded product info typing with optional sibling bundle identifier. |
| build/gulpfile.vscode.ts | Preserves host darwinSiblingBundleIdentifier when generating product.sub.json for embedded builds. |
f96efb6 to
471ccaa
Compare
bpasero
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/6966