Skip to content

feat: support launching agents/vscode app without protocol handler#310773

Merged
deepak1556 merged 1 commit intomainfrom
robo/open_with_action_agents
Apr 16, 2026
Merged

feat: support launching agents/vscode app without protocol handler#310773
deepak1556 merged 1 commit intomainfrom
robo/open_with_action_agents

Conversation

@deepak1556
Copy link
Copy Markdown
Collaborator

@deepak1556 deepak1556 added this to the 1.117.0 milestone Apr 16, 2026
@deepak1556 deepak1556 self-assigned this Apr 16, 2026
Copilot AI review requested due to automatic review settings April 16, 2026 15:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Screenshot Changes

Base: 3267a57d Current: 360d5a75

Changed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
editor/inlineChatAffordance/InlineChatOverlay/Light
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a native “launch sibling app” pathway (host ↔ embedded) so Agents/VS Code can be launched without relying on OS protocol handler registration, improving robustness for packaged/enterprise scenarios.

Changes:

  • Add INativeHostService.launchSiblingApp() and implement it in the Electron main process using a new platform/native/node/siblingApp.ts helper.
  • Switch “Open Agents Application” to launch the sibling app directly on macOS/Windows (built builds).
  • Add a Sessions desktop contribution to “Open in VS Code” by launching the host app with CLI args, and extend product/build metadata to support sibling bundle IDs.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/vs/workbench/test/electron-browser/workbenchTestServices.ts Adds a test stub for the new native host API.
src/vs/workbench/contrib/chat/electron-browser/agentSessions/agentSessionsActions.ts Uses native sibling-app launch instead of protocol opener in built desktop scenarios.
src/vs/sessions/sessions.desktop.main.ts Registers a desktop-specific “Open in VS Code” override contribution.
src/vs/sessions/contrib/chat/electron-browser/openInVSCode.contribution.ts Implements desktop override that launches the host app with --folder-uri and --open-url.
src/vs/platform/native/node/siblingApp.ts New helper to resolve & spawn the sibling application per-platform.
src/vs/platform/native/electron-main/nativeHostMainService.ts Wires the new method through the main-process native host service.
src/vs/platform/native/common/native.ts Extends native host interface with launchSiblingApp.
src/vs/code/node/cli.ts Reuses sibling resolution logic for --agents on Windows; simplifies macOS embedded launch to open -b.
src/vs/base/common/product.ts Adds darwinSiblingBundleIdentifier to product configuration types.
build/lib/embeddedType.ts Extends embedded product info typing with optional sibling bundle identifier.
build/gulpfile.vscode.ts Preserves host darwinSiblingBundleIdentifier when generating product.sub.json for embedded builds.

Comment thread src/vs/platform/native/node/siblingApp.ts
Comment thread src/vs/sessions/contrib/chat/electron-browser/openInVSCode.contribution.ts Outdated
@deepak1556 deepak1556 force-pushed the robo/open_with_action_agents branch from f96efb6 to 471ccaa Compare April 16, 2026 16:14
@deepak1556 deepak1556 requested a review from bpasero April 16, 2026 16:15
@deepak1556 deepak1556 marked this pull request as ready for review April 16, 2026 17:09
@deepak1556 deepak1556 merged commit 347ce1c into main Apr 16, 2026
26 checks passed
@deepak1556 deepak1556 deleted the robo/open_with_action_agents branch April 16, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants