agentHost: make file paths in tool invocation messages nicer#310813
Merged
connor4312 merged 1 commit intomainfrom Apr 16, 2026
Merged
agentHost: make file paths in tool invocation messages nicer#310813connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
Does proper markdown linking
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Light
| Before | After |
|---|---|
 |
 |
roblourens
reviewed
Apr 16, 2026
| * as a clickable file widget in the chat UI. | ||
| */ | ||
| function formatPathAsMarkdownLink(path: string): string { | ||
| return `[](${URI.file(path).toString()})`; |
Member
There was a problem hiding this comment.
I think this should be on the client side, not the agent host
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Agent Host/Copilot tool messaging to support richer rendering (notably file “pills” via markdown links) and consolidates permission-request display logic alongside existing tool display helpers.
Changes:
- Switch tool invocation/past-tense messages to return
StringOrMarkdownand render file paths as[](file://...)links for clickable file widgets. - Move/centralize SDK permission request display derivation into
copilotToolDisplay.ts(including typed request helpers). - Update
IAgentToolStartEvent.invocationMessagetoStringOrMarkdownto align with protocol/tool UI rendering.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/node/copilot/copilotToolDisplay.ts | Adds markdown-link formatting for file paths; returns StringOrMarkdown; introduces permission display helpers. |
| src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts | Consumes the new permission display helper and propagates permissionPath from it. |
| src/vs/platform/agentHost/common/agentService.ts | Changes tool_start invocationMessage type to StringOrMarkdown. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 1
Comment on lines
+470
to
+472
| return { | ||
| confirmationTitle: serverName ? `${serverName}: ${title}` : title, | ||
| invocationMessage: serverName ? `${serverName}: ${title}` : title, |
There was a problem hiding this comment.
The MCP permission title/message is built with a template literal (e.g. ${serverName}: ${title}), which bypasses localization and violates the repo’s pattern of using localize() with placeholders for user-facing strings. Please format this via a localized string (e.g. localize('…', "{0}: {1}", serverName, title)) and reuse it for both confirmationTitle and invocationMessage to keep them consistent.
Suggested change
| return { | |
| confirmationTitle: serverName ? `${serverName}: ${title}` : title, | |
| invocationMessage: serverName ? `${serverName}: ${title}` : title, | |
| const message = serverName ? localize('copilot.permission.mcp.serverAndTool', "{0}: {1}", serverName, title) : title; | |
| return { | |
| confirmationTitle: message, | |
| invocationMessage: message, |
roblourens
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does proper markdown linking