chat customizations: splash when MCP/plugins disabled#310847
Merged
joshspicer merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
Added (8)
chat/aiCustomizations/aiCustomizationManagementEditor/McpDisabledByUser/Light
chat/aiCustomizations/aiCustomizationManagementEditor/McpDisabledByPolicy/Light
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsDisabledByUser/Light
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsDisabledByPolicy/Light
chat/aiCustomizations/aiCustomizationManagementEditor/McpDisabledByUser/Dark
chat/aiCustomizations/aiCustomizationManagementEditor/McpDisabledByPolicy/Dark
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsDisabledByUser/Dark
chat/aiCustomizations/aiCustomizationManagementEditor/PluginsDisabledByPolicy/Dark
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an “access disabled” splash state to the Chat Customizations management editor’s MCP Servers and Plugins tabs when their respective settings (or enterprise policy) disable access, and adds component fixtures to cover the new UI states.
Changes:
- Add disabled/policy-locked splash UI to
McpListWidgetandPluginListWidget, reacting live to configuration changes. - Add a shared CSS modifier (
.access-disabled) to hide the normal widget UI and show the disabled splash. - Add new component fixtures for MCP/Plugins disabled-by-user vs disabled-by-policy states.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/test/browser/componentFixtures/sessions/aiCustomizationManagementEditor.fixture.ts | Adds fixtures rendering MCP/Plugins disabled-by-user/policy states by mocking configuration values. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts | Implements the plugins “access disabled” splash state driven by chat.plugins.enabled + policy detection. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css | Adds .mcp-disabled-state styling and .access-disabled modifier to block the rest of the widget UI. |
| src/vs/workbench/contrib/chat/browser/aiCustomization/mcpListWidget.ts | Implements the MCP “access disabled” splash state driven by chat.mcp.access + policy detection. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
joshspicer
force-pushed
the
agents/splash-page-chat-customizations
branch
2 times, most recently
from
a2d2dd2 to
052e8e4
Compare
roblourens
previously approved these changes
Apr 17, 2026
joshspicer
force-pushed
the
agents/splash-page-chat-customizations
branch
from
052e8e4 to
a5c3c33
Compare
rzhao271
previously approved these changes
Apr 17, 2026
Block the MCP servers and Plugins tabs in the chat customizations editor when their respective access settings are disabled, including via enterprise policy. - McpListWidget watches `chat.mcp.access`; shows splash when value is `none`. If `policyValue === 'none'`, shows policy-locked message and hides the "Open Setting" button. - PluginListWidget watches `chat.plugins.enabled` with the same user/policy distinction. - Reuse `.mcp-list-widget` root class so the new `.mcp-disabled-state` CSS applies to both widgets via a single `.access-disabled` modifier. - Add Dark/Light fixtures for both widgets in user-disabled and policy-locked states (8 new screenshots). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
joshspicer
force-pushed
the
agents/splash-page-chat-customizations
branch
from
a5c3c33 to
6712342
Compare
rzhao271
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block the MCP servers and Plugins tabs in the chat customizations editor when their respective access settings are disabled, including via enterprise policy.
Behavior
McpListWidgetwatcheschat.mcp.access. When the value isnone, the tab is replaced by a splash with a shield icon, explanation, and an "Open Setting" button. IfpolicyValue === 'none'(locked byChatMCPpolicy), the message switches to "disabled by your organization's policy" and the settings button is hidden.PluginListWidgetwatcheschat.plugins.enabled(boolean, policyChatPluginsEnabled) with the same user-vs-policy distinction.onDidChangeConfiguration— no reload required when the setting toggles.Implementation notes
.mcp-list-widgetroot class on both widgets so a single.access-disabledCSS modifier (inaiCustomizationManagement.css) blocks the rest of the page and reveals.mcp-disabled-state.IConfigurationService.inspect(...).policyValue, matching the existing pattern inmodePickerActionItem.ts,chatModes.ts,chatInputPart.ts, etc.Fixtures
Adds 4 new component fixtures (× Dark/Light = 8 screenshots) in
aiCustomizationManagementEditor.fixture.ts:McpDisabledByUserMcpDisabledByPolicyPluginsDisabledByUserPluginsDisabledByPolicy