Fix unescaped icon and undefined text in terminal tool confirmations#311037
Merged
meganrogge merged 2 commits intomainfrom Apr 17, 2026
Merged
Fix unescaped icon and undefined text in terminal tool confirmations#311037meganrogge merged 2 commits intomainfrom
meganrogge merged 2 commits intomainfrom
Conversation
Collaborator
Author
|
cc @anthonykim1 |
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes confirmation/markdown rendering issues in the terminal chat agent tools by removing an unescaped codicon from a command link and ensuring confirmation messages don’t surface undefined when optional fields are missing.
Changes:
- Remove
$(terminal)from the “Focus Terminal” markdown link insend_to_terminalconfirmation messaging. - Add localized fallback text when
explanation/goalare missing inrun_in_terminalconfirmation messages. - Add/extend tests covering
send_to_terminalconfirmation behavior and auto-approve behavior.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/electron-browser/runInTerminalTool.test.ts | Adds a regression test intended to ensure “undefined” doesn’t appear in confirmations when explanation/goal are missing. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/test/browser/sendToTerminalTool.test.ts | Adds tests for confirmation behavior in default vs auto-approve permission levels and for the “Focus Terminal” link text. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/sendToTerminalTool.ts | Removes $(terminal) from the “Focus Terminal” link label to avoid literal rendering. |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Introduces localized fallback strings for missing explanation/goal in confirmation messages. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 1
connor4312
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309505
Fixes #304351
$(terminal)ThemeIcon from the send_to_terminal Focus Terminal markdown link, which rendered as literal textexplanation/goalare undefined in run_in_terminal confirmation messages