ci: allow copilot extension version bump in engineering system check#311122
Merged
benvillalobos merged 2 commits intomainfrom Apr 18, 2026
Merged
ci: allow copilot extension version bump in engineering system check#311122benvillalobos merged 2 commits intomainfrom
benvillalobos merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the no-engineering-system-changes workflow to keep allowing automated version bump PRs from vs-code-engineering[bot] now that the automation also updates the Copilot extension’s package.json/package-lock.json.
Changes:
- Expands the bot exception’s allowed file set to include
extensions/copilot/package.jsonandextensions/copilot/package-lock.jsonalongside the rootpackage.json/package-lock.json. - Adds strict validation that
extensions/copilot/package.jsondiffs only touch the"version"and"vscode"fields (via exact changed-line and key counts). - Refactors file-set checks to sort the changed-file list once and reuse it for comparisons.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/no-engineering-system-changes.yml |
Extends the version-bump bot exception to cover Copilot extension version/engine bumps while keeping strict file-set and diff-shape validation. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
bryanchen-d
approved these changes
Apr 17, 2026
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
editor/inlineCompletions/other/JumpToHint/Dark
| Before | After |
|---|---|
 |
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example PR this should let through.
The
no-engineering-system-changesworkflow blocks PRs that modify engineering system files (.github/workflows/,build/,package.json). It has a special exception forvs-code-engineering[bot]to allow automated distro and version bumps to the rootpackage.json(+package-lock.json).The version bump automation now also updates
extensions/copilot/package.json(version +engines.vscodefields) andextensions/copilot/package-lock.json. The existing exception didn't account for these files, causing PR #309360 to fail.This change expands the exception to also allow the 4-file version bump case:
package.json— only"version"field (2 changed lines)package-lock.json— trusted, not inspected (same as before)extensions/copilot/package.json— only"version"and"vscode"fields (4 changed lines)extensions/copilot/package-lock.json— trusted, not inspectedThe validation remains strict: exact file-set matching, exact line-count checks, and bot-identity gating.