inlineEdits: remove InlineEditsCheckEditWindowOnReuse config flag#311255
Merged
inlineEdits: remove InlineEditsCheckEditWindowOnReuse config flag#311255
Conversation
The edit window cursor check on request reuse is now always enabled, so the experiment-based config flag is no longer needed. Remove the config definition, the INesConfigs field, and the guard in the cursorInRequestEditWindow predicate. Update the test to drop the beforeEach that set the flag to true. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the experiment-based chat.advanced.inlineEdits.checkEditWindowOnReuse flag now that the “cursor in request edit window” check for request reuse is always enabled in the inline edits (NES) flow.
Changes:
- Removed the
InlineEditsCheckEditWindowOnReuseteam-internal config key definition. - Dropped
isCheckEditWindowOnReusefromINesConfigsand stopped reading it when building NES configs. - Made the edit-window cursor check unconditional when deciding whether an in-flight request can be reused, and simplified the related test setup.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/platform/configuration/common/configurationService.ts | Removes the experiment-based config key definition for the deprecated flag. |
| extensions/copilot/src/extension/inlineEdits/node/nesConfigs.ts | Updates INesConfigs to remove the flag field. |
| extensions/copilot/src/extension/inlineEdits/node/nextEditProvider.ts | Stops reading the flag and makes the edit-window cursor check unconditional for reuse logic. |
| extensions/copilot/src/extension/inlineEdits/test/node/nextEditProviderSpeculative.spec.ts | Removes test setup that forced the flag on, since the behavior is now always enabled. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 0
Contributor
Screenshot ChangesBase: Changed (2)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/NeedsInput/Dark
| Before | After |
|---|---|
 |
 |
roblourens
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The edit window cursor check on request reuse is now always enabled, so the experiment-based config flag
chat.advanced.inlineEdits.checkEditWindowOnReuseis no longer needed.Changes
configurationService.ts: RemoveInlineEditsCheckEditWindowOnReuseconfig definitionnesConfigs.ts: RemoveisCheckEditWindowOnReusefield fromINesConfigsinterfacenextEditProvider.ts: Remove config read fromdetermineNesConfigsand drop theisCheckEditWindowOnReuseguard in thecursorInRequestEditWindowpredicate — the check is now unconditionalnextEditProviderSpeculative.spec.ts: RemovebeforeEachthat set the flag totrue(no longer needed since behavior is always on)