Skip to content

add hint for chat.permissions.default and agents input fix#311273

Merged
justschen merged 2 commits intomainfrom
justin/malamar
Apr 20, 2026
Merged

add hint for chat.permissions.default and agents input fix#311273
justschen merged 2 commits intomainfrom
justin/malamar

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

@justschen justschen commented Apr 19, 2026

687-Malamar

Copilot AI review requested due to automatic review settings April 19, 2026 22:33
@justschen justschen enabled auto-merge (squash) April 19, 2026 22:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 19, 2026

Screenshot Changes

Base: 0c576529 Current: 394d10c4

Changed (1)

editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates chat permission-related UX by adding a direct Settings link in elevated-permission warning dialogs, and adjusts the Sessions window permission picker to reflect the configured default permission level (chat.permissions.default).

Changes:

  • Add an “open settings” hint/link to the Bypass Approvals and Autopilot warning dialog details.
  • Initialize the Sessions window permission picker UI from chat.permissions.default (with validation via isChatPermissionLevel).
  • Add the same settings hint/link to the Agent Host session config picker’s auto-approve confirmation dialog.
Show a summary per file
File Description
src/vs/workbench/contrib/chat/browser/widget/input/permissionPickerActionItem.ts Adds a Settings deep-link in permission warning dialog markdown details.
src/vs/sessions/contrib/copilotChatSessions/browser/permissionPicker.ts Initializes the Sessions permission picker from chat.permissions.default and adds the same Settings deep-link in warnings.
src/vs/sessions/contrib/chat/browser/agentHostSessionConfigPicker.ts Extends Agent Host auto-approve confirmation dialog details with a Settings deep-link.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Comment thread src/vs/sessions/contrib/copilotChatSessions/browser/permissionPicker.ts Outdated
Comment thread src/vs/sessions/contrib/chat/browser/agentHostSessionConfigPicker.ts Outdated
@justschen justschen merged commit 2f08b1e into main Apr 20, 2026
40 of 41 checks passed
@justschen justschen deleted the justin/malamar branch April 20, 2026 16:55
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 20, 2026
@justschen justschen added ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Apr 20, 2026
@vs-code-engineering vs-code-engineering Bot added release-cherry-pick Automated cherry-pick between release and main branches and removed ~release-cherry-pick Trigger: cherry-pick this PR to the latest release branch labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-cherry-pick Automated cherry-pick between release and main branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants