[Error] [UriError] joinPath on URI without path

[aeschli]

Fixes #310752

[github-actions]

Screenshot Changes

Base: 341ef7db Current: 0dedbbc1

Changed (6)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Dark

Before	After

agentSessionsViewer/CompletedUnread/Dark

Before	After

agentSessionsViewer/CompletedUnread/Light

Before	After

agentSessionsViewer/WithMarkdownBadge/Dark

Before	After

agentSessionsViewer/WithMarkdownBadge/Light

Before	After

agentSessionsViewer/ApprovalRowLongLabel/Light

Before	After

[Copilot]

Pull request overview

Fixes an Agents-window crash caused by calling URI.joinPath on a repository URI that had an empty path when repository metadata was missing.

Changes:

• Ensure the fallback repository URI includes a non-empty path (unknown:///) so downstream joinPath usage doesn’t throw.

Show a summary per file

File	Description
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts	Adjusts the fallback repository URI to include a path, preventing joinPath from throwing when repo metadata is absent.

Copilot's findings

• Files reviewed: 1/1 changed files
• Comments generated: 2

[Copilot]

This fixes a crash path (repo URI missing -> joinPath throws), but there’s no regression test covering the repoUri === undefined case. The existing unit tests always set metadata.repositoryPath, so this scenario isn’t exercised; consider adding a test that creates an agent session without repository metadata and asserts the adapted workspace/repository URIs are still safe to joinPath against (no empty uri.path).

See below for a potential fix:

	private _toSafeWorkspaceUri(uri: URI | undefined): URI {
		const safeUri = uri ?? URI.from({ scheme: 'unknown', path: '/' });
		return safeUri.path ? safeUri : safeUri.with({ path: '/' });
	}

	private _buildWorkspace(session: IAgentSession): ISessionWorkspace | undefined {
		const [repoUri, worktreeUri, branchName, baseBranchName, baseBranchProtected] = this._extractRepositoryFromMetadata(session);
		const safeRepositoryUri = this._toSafeWorkspaceUri(repoUri);
		const safeWorkingDirectoryUri = this._toSafeWorkspaceUri(worktreeUri ?? repoUri);

		const repository: ISessionRepository = {
			uri: safeRepositoryUri,
			workingDirectory: safeWorkingDirectoryUri,