Remove old MSGestureEvent based conditional#311479
Merged
Conversation
I think this only existed in ie/edge?
Contributor
There was a problem hiding this comment.
Pull request overview
Removes a legacy MSGestureEvent fallback path in StandardMouseEvent that computed pageX/pageY from clientX/clientY + scroll offsets, simplifying mouse position handling now that legacy IE/Edge event models are no longer supported.
Changes:
- Remove conditional handling for missing
pageX/pageYinStandardMouseEvent. - Always use
MouseEvent.pageX/pageYfor position computation.
Show a summary per file
| File | Description |
|---|---|
| src/vs/base/browser/mouseEvent.ts | Simplifies StandardMouseEvent coordinate extraction by removing the legacy MSGestureEvent branch. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
DonJayamanne
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this only existed in ie/edge which we haven't supported for a while