Skip to content

Remove empty dispose overrides#311483

Merged
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/new-mole
Apr 20, 2026
Merged

Remove empty dispose overrides#311483
mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz:dev/mjbvz/new-mole

Conversation

@mjbvz
Copy link
Copy Markdown
Collaborator

@mjbvz mjbvz commented Apr 20, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 20, 2026 20:42
@mjbvz mjbvz enabled auto-merge April 20, 2026 20:42
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@alexr00

Matched files:

  • src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes no-op dispose() overrides that only forwarded to super.dispose(), reducing boilerplate across several workbench/editor/platform classes while preserving disposal behavior via their base classes (Disposable, Widget, ViewPart, etc.).

Changes:

  • Removed redundant public override dispose(): void { super.dispose(); } implementations from multiple classes.
  • Simplified affected files without changing runtime logic, since base classes already provide the dispose() implementation.
Show a summary per file
File Description
src/vs/workbench/services/dialogs/browser/simpleFileDialog.ts Removes a no-op dispose() override; relies on Disposable.dispose() as before.
src/vs/workbench/contrib/codeEditor/electron-browser/selectionClipboard.ts Removes a no-op dispose() override in SelectionClipboard.
src/vs/platform/keybinding/common/abstractKeybindingService.ts Removes a no-op dispose() override in the abstract service base.
src/vs/editor/standalone/browser/standaloneCodeEditor.ts Removes no-op dispose() overrides in standalone editor classes.
src/vs/editor/common/viewLayout/viewLayout.ts Removes a no-op dispose() override in ViewLayout.
src/vs/editor/browser/viewParts/scrollDecoration/scrollDecoration.ts Removes a no-op dispose() override; base ViewPart.dispose() continues to run.
src/vs/editor/browser/viewParts/rulers/rulers.ts Removes a no-op dispose() override in Rulers.
src/vs/editor/browser/viewParts/margin/margin.ts Removes a no-op dispose() override in Margin.
src/vs/editor/browser/viewParts/editorScrollbar/editorScrollbar.ts Removes a no-op dispose() override in EditorScrollbar.
src/vs/editor/browser/viewParts/blockDecorations/blockDecorations.ts Removes a no-op dispose() override in BlockDecorations.
src/vs/editor/browser/services/editorWorkerService.ts Removes a no-op dispose() override in EditorWorkerService.
src/vs/editor/browser/controller/mouseHandler.ts Removes a no-op dispose() override in MouseDownOperation.
src/vs/base/browser/ui/findinput/replaceInput.ts Removes a no-op dispose() override; Widget already extends Disposable.

Copilot's findings

  • Files reviewed: 13/13 changed files
  • Comments generated: 0

@mjbvz mjbvz merged commit 2b6f58f into microsoft:main Apr 20, 2026
30 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants