Don't expose public mutable properties from actionbar#311501
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Apr 20, 2026
Merged
Don't expose public mutable properties from actionbar#311501mjbvz merged 1 commit intomicrosoft:mainfrom
mjbvz merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent external mutation of ActionBar internals by making viewItems non-mutable from the outside and tightening element property mutability.
Changes:
- Replace public
viewItemsarray with a private backing field and a (readonly) accessor. - Make
domNodereadonly to prevent reassignment after construction. - Simplify
getWidth/getHeightimplementations with optional chaining/nullish coalescing.
Show a summary per file
| File | Description |
|---|---|
| src/vs/base/browser/ui/actionbar/actionbar.ts | Encapsulates viewItems, makes domNode readonly, and simplifies dimension getters. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
mjbvz
force-pushed
the
dev/mjbvz/plain-llama
branch
from
a02b1ee to
bef799f
Compare
roblourens
approved these changes
Apr 20, 2026
mjbvz
commented
Apr 20, 2026
| } | ||
|
|
||
| getHeight(index: number): number { | ||
| if (index >= 0 && index < this.actionsList.children.length) { |
Collaborator
Author
There was a problem hiding this comment.
Whoops wasn't directly part of this change but should be ok to include too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.