Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves input handling for picker triggers so they respond reliably to both mouse clicks and touch taps (notably on iOS), aligning the pickers’ behavior across the workbench chat model picker and the Sessions window pickers.
Changes:
- Switch workbench chat model picker trigger to
addDisposableGenericMouseDownListenerso iOS usespointerdownwheremousedowncan be unreliable. - Add touch
Gesturetargeting and listen for bothCLICKandTapon several Sessions window picker triggers. - Keep existing keyboard activation behavior (Enter/Space) unchanged.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Use generic mouse down listener to get pointer events on iOS for opening the model picker. |
| src/vs/sessions/contrib/copilotChatSessions/browser/permissionPicker.ts | Add Gesture + tap handling so the permission picker opens on touch. |
| src/vs/sessions/contrib/copilotChatSessions/browser/modelPicker.ts | Add Gesture + tap handling so the model picker opens on touch. |
| src/vs/sessions/contrib/copilotChatSessions/browser/modePicker.ts | Add Gesture + tap handling so the mode picker opens on touch. |
| src/vs/sessions/contrib/copilotChatSessions/browser/isolationPicker.ts | Add Gesture + tap handling so the isolation picker opens on touch. |
| src/vs/sessions/contrib/copilotChatSessions/browser/claudePermissionModePicker.ts | Add Gesture + tap handling so the Claude permission mode picker opens on touch. |
| src/vs/sessions/contrib/copilotChatSessions/browser/branchPicker.ts | Add Gesture + tap handling so the branch picker opens on touch. |
| src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts | Add Gesture + tap handling so the workspace picker opens on touch. |
| src/vs/sessions/contrib/chat/browser/sessionTypePicker.ts | Add Gesture + tap handling so the session type picker opens on touch. |
Copilot's findings
- Files reviewed: 9/9 changed files
- Comments generated: 1
Contributor
Screenshot ChangesBase: Changed (5)
|
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/CompletedUnread/Light
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Dark
| Before | After |
|---|---|
 |
 |
agentSessionsViewer/WithMarkdownBadge/Light
| Before | After |
|---|---|
 |
 |
bpasero
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot copilot@github.com