Agents - rework open changes action

[lszomoru]

No description provided.

[github-actions]

Screenshot Changes

Base: df028283 Current: 7794185b

Changed (1)

agentSessionsViewer/ApprovalRowLongLabel/Light

Before	After

[Copilot]

Pull request overview

This PR reworks “Open Changes” handling in the Agents Sessions Changes view by moving the per-file toolbar action registration to the per-change toolbar menu and by changing how selected resources are mapped to session changes before opening editors.

Changes:

• Register the per-file “Open File/Open Changes” action under MenuId.ChatEditingSessionChangeToolbar (instead of the session-level changes toolbar).
• Rework “Open Changes” to collect matching session changes for the selected resources and open them as editors in a batch.

Show a summary per file

File	Description
src/vs/sessions/contrib/changes/browser/changesViewActions.ts	Updates menu placement for per-file actions and refactors the “Open Changes” action to filter session changes and open them in bulk.

Copilot's findings

Comments suppressed due to low confidence (2)

src/vs/sessions/contrib/changes/browser/changesViewActions.ts:261

• editorService.openEditor({ original: { resource: change.originalUri }, modified: { resource: change.modifiedUri } }) does not handle added/deleted changes where originalUri or modifiedUri can be undefined (notably for IChatSessionFileChange2). This ends up passing resource: undefined into the untyped diff input and can open an unintended untitled editor or otherwise fail. Handle the 3 cases explicitly: (1) both URIs -> diff editor, (2) deletion -> open originalUri, (3) addition -> open modifiedUri/change.uri as a normal resource editor (similar to ChangesViewPane._openFileItem).

		await Promise.all(changes.map(change => editorService.openEditor({
			original: { resource: change.originalUri },
			modified: { resource: change.modifiedUri }
		})));

src/vs/sessions/contrib/changes/browser/changesViewActions.ts:261

• Opening multiple editors via Promise.all(changes.map(...openEditor)) can produce non-deterministic editor activation order (whichever promise resolves last wins) and repeats group/override resolution per editor. Prefer editorService.openEditors(...) for batch opens (it resolves target groups once and opens per-group in a controlled way), or open sequentially if you need deterministic “last opened is active” behavior.

		await Promise.all(changes.map(change => editorService.openEditor({
			original: { resource: change.originalUri },
			modified: { resource: change.modifiedUri }
		})));

• Files reviewed: 1/1 changed files
• Comments generated: 1