Skip to content

fix compilation#311793

Merged
sandy081 merged 1 commit intomainfrom
sandy081/dead-pigeon
Apr 21, 2026
Merged

fix compilation#311793
sandy081 merged 1 commit intomainfrom
sandy081/dead-pigeon

Conversation

@sandy081
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 21, 2026 22:04
@sandy081 sandy081 enabled auto-merge (squash) April 21, 2026 22:04
@sandy081 sandy081 self-assigned this Apr 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a stale reference in the Copilot chat sessions provider that prevented TypeScript compilation, aligning the first-chat commit flow with the provider’s current internal grouping/cache model.

Changes:

  • Remove a call to this._groupModel.addChat(...) during the “temp session → committed session” swap in _sendFirstChat.
Show a summary per file
File Description
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts Drops an invalid/obsolete group-model update during session commit to restore compilation.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@github-actions
Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: 51d818fe Current: dab99fd6

Changed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/McpBrowseMode/Light
Before After
before after
editor/inlineCompletions/other/JumpToHint/Dark
Before After
before after

@sandy081 sandy081 merged commit b000854 into main Apr 21, 2026
30 checks passed
@sandy081 sandy081 deleted the sandy081/dead-pigeon branch April 21, 2026 22:25
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants