Conversation
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the chat prompt “skill” parsing and validation behavior to better align skill identity with its containing folder and to relax header requirements while maintaining model-invocation safety.
Changes:
- Change
getCleanPromptName()forSKILL.md(case-insensitive) to return the parent folder name instead ofSKILL. - Relax skill header validation to allow omitted
name/description, but require a description when certain invocability attributes are set. - Exclude skills without a description from the “model-invocable skills” set used for automatic instructions, and update tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/config/promptFileLocations.ts | Adjusts clean-name computation for skills to use folder names. |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptValidator.ts | Updates skill validation rules around missing name/description and conditional description requirements. |
| src/vs/workbench/contrib/chat/common/promptSyntax/computeAutomaticInstructions.ts | Filters out skills lacking descriptions from model-invocation loading and logs skip reasons. |
| src/vs/workbench/contrib/chat/test/common/promptSyntax/config/promptFileLocations.test.ts | Updates expectations for skill clean-name behavior across filename casing variants. |
| src/vs/workbench/contrib/chat/test/browser/promptSyntax/languageProviders/promptValidator.test.ts | Updates/extends tests for new skill header validation behavior. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 2
aeschli
requested changes
Apr 22, 2026
Yoyokrazy
previously approved these changes
Apr 22, 2026
aeschli
previously approved these changes
Apr 23, 2026
Yoyokrazy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #297484
Fixes #294747