sessions: fix workspace picker and session options resetting on new chat widget#312072
Merged
connor4312 merged 3 commits intomainfrom Apr 23, 2026
Merged
sessions: fix workspace picker and session options resetting on new chat widget#312072connor4312 merged 3 commits intomainfrom
connor4312 merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the Sessions window “New Session” experience by preserving the in-progress (unsent) session instance when navigating away and back, preventing the workspace picker and session configuration from resetting due to new widget instantiation.
Changes:
- Track and restore a “pending new session” in
SessionsManagementServicesoopenNewSessionViewcan rehydrate UI state from the existing session object. - Clear the pending session when the session is unset or after a request is sent.
- Update
NewChatWidgetinitialization to reuse an already-restored active session and synchronize the workspace picker without triggering a new session creation.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/services/sessions/browser/sessionsManagementService.ts | Adds _pendingNewSession tracking and restores it when returning to the new-session view. |
| src/vs/sessions/contrib/chat/browser/newChatViewPane.ts | Avoids recreating a new session if one is already active (restored), and syncs the workspace picker accordingly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
…rsist # Conflicts: # src/vs/sessions/services/sessions/browser/sessionsManagementService.ts
roblourens
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.