Skip to content

sessions: enable Claude agent sessions by default and rename setting#312248

Merged
TylerLeonhardt merged 1 commit intomainfrom
tyler/disastrous-mongoose
Apr 23, 2026
Merged

sessions: enable Claude agent sessions by default and rename setting#312248
TylerLeonhardt merged 1 commit intomainfrom
tyler/disastrous-mongoose

Conversation

@TylerLeonhardt
Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt commented Apr 23, 2026

Summary

  • Renames sessions.chatSessions.claude.enabled to sessions.chat.claudeAgent.enabled to align with the github.copilot.chat.claudeAgent.enabled convention
  • Enables the setting by default (true) and removes the experimental tag
  • Updates description to match the copilot extension's wording
  • Removes redundant ?? false fallbacks from getValue calls (config registry provides the default)
  • Updates tests and docs to reflect the new default

Test plan

  • All 56 unit tests pass (copilotChatSessionsProvider.test.ts)
  • TypeScript compilation passes
  • Verify Claude session type appears by default in the Agents app
  • Verify disabling the setting hides Claude sessions

Renames `sessions.chatSessions.claude.enabled` to `sessions.chat.claudeAgent.enabled`
to align with the `github.copilot.chat.claudeAgent.enabled` convention. Enables the
setting by default and removes the experimental tag and warning text from the
description. Updates tests to reflect the new default.
Copilot AI review requested due to automatic review settings April 23, 2026 22:33
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) April 23, 2026 22:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables Claude agent sessions by default in the Sessions (Agents) window and aligns the controlling setting name with the Copilot extension’s ...claudeAgent.enabled convention.

Changes:

  • Renames the Claude enablement setting to sessions.chat.claudeAgent.enabled and updates references/docs.
  • Switches the setting default to true and updates provider/test expectations accordingly.
  • Removes redundant ?? false fallbacks when reading the Claude setting value.
Show a summary per file
File Description
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts Renames the Claude setting key and relies on the configuration default for enablement.
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessions.contribution.ts Updates configuration schema: new key, default true, revised description.
src/vs/sessions/contrib/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts Updates tests to reflect Claude being enabled by default and toggling behavior.
src/vs/sessions/contrib/copilotChatSessions/COPILOT_CHAT_SESSIONS_PROVIDER.md Updates documentation to reflect the new setting key and default.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

@TylerLeonhardt TylerLeonhardt merged commit 0689763 into main Apr 23, 2026
30 checks passed
@TylerLeonhardt TylerLeonhardt deleted the tyler/disastrous-mongoose branch April 23, 2026 22:55
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants