Skip to content

refactor: replace IInlineChatEditStrategy with InlineChatToolCalling for improved edit handling#312329

Merged
jrieken merged 3 commits intomainfrom
joh/content-tyrannosaurus
Apr 24, 2026
Merged

refactor: replace IInlineChatEditStrategy with InlineChatToolCalling for improved edit handling#312329
jrieken merged 3 commits intomainfrom
joh/content-tyrannosaurus

Conversation

@jrieken
Copy link
Copy Markdown
Member

@jrieken jrieken commented Apr 24, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 24, 2026 10:46
@jrieken jrieken enabled auto-merge (squash) April 24, 2026 10:46
@jrieken jrieken self-assigned this Apr 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Copilot inline chat editing flow to use a dedicated tool-calling loop (replacing the prior edit-strategy abstraction), and removes now-obsolete configuration/telemetry related to the previous heuristic selection-handling path.

Changes:

  • Replaces IInlineChatEditStrategy-based branching with InlineChatToolCalling in the inline chat intent flow.
  • Removes the inlineChat.selectionRatioThreshold experimental configuration (and its package.json/nls entries).
  • Removes selection-length telemetry plumbing tied to AST/selection adjustment metadata.
Show a summary per file
File Description
extensions/copilot/src/platform/configuration/common/configurationService.ts Removes the InlineChatSelectionRatioThreshold config key constant.
extensions/copilot/src/extension/prompts/node/inline/test/inlineChat2Prompt.spec.tsx Updates test import to use the new prompt module location.
extensions/copilot/src/extension/prompts/node/inline/inlineChatEditCodePrompt.tsx Removes DocumentToAstSelectionData telemetry metadata emission and related imports.
extensions/copilot/src/extension/prompt/node/chatParticipantTelemetry.ts Removes selection length measurements and the associated GDPR fields.
extensions/copilot/src/extension/intents/node/editCodeIntent.ts Removes a stale commented telemetry line referencing removed metadata.
extensions/copilot/src/extension/inlineChat/node/inlineChatPrompt.tsx Adjusts import paths after prompt/module reorganization.
extensions/copilot/package.nls.json Removes localized description for the deleted config setting.
extensions/copilot/package.json Removes the github.copilot.chat.inlineChat.selectionRatioThreshold configuration contribution.

Copilot's findings

  • Files reviewed: 9/9 changed files
  • Comments generated: 2

@jrieken jrieken merged commit 75dcfb9 into main Apr 24, 2026
30 checks passed
@jrieken jrieken deleted the joh/content-tyrannosaurus branch April 24, 2026 12:15
@vs-code-engineering vs-code-engineering Bot added this to the 1.118.0 milestone Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants