Conversation
Co-authored-by: Copilot <copilot@github.com>
lszomoru
approved these changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup/refactoring across inline chat (workbench) and Copilot inline features, including moving helper logic into more appropriate modules and tightening some APIs.
Changes:
- Refactors terminal inline chat to use a terminal-specific
InlineChatWidgetsubclass and removes generic helper APIs from the base widget. - Renames/cleans up inline chat configuration and session types, and consolidates contribution registration.
- Extracts “review edits” functionality into a dedicated chat actions module and adds Copilot inline-edits natural-language detection + InlineChat2 prompt scaffolding.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chat/browser/terminalChatWidget.ts | Introduces TerminalInlineChatWidget subclass and wires terminal chat to it. |
| src/vs/workbench/contrib/inlineChat/common/inlineChat.ts | Removes an unused config key and renames notebookAgent enum member to NotebookAgent. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatWidget.ts | Makes InlineChatWidget abstract and trims APIs; exposes chatWidget directly. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionServiceImpl.ts | Renames IInlineChatSession2 usage to IInlineChatSession and updates config key reference. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatSessionService.ts | Renames the session interface and narrows helper function exports. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatNotebook.ts | Removes unused editor service injection. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatDefaultModel.ts | Stops self-registering; relies on contribution registration. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChatController.ts | Removes unrelated helper functions and updates types/config key usage. |
| src/vs/workbench/contrib/inlineChat/browser/inlineChat.contribution.ts | Registers notebook/default-model contributions via registerWorkbenchContribution2. |
| src/vs/workbench/contrib/chat/browser/actions/reviewEdits.ts | New home for reviewEdits / reviewNotebookEdits. |
| src/vs/workbench/contrib/chat/browser/actions/codeBlockOperations.ts | Updates imports to use extracted reviewEdits module. |
| src/vs/workbench/contrib/chat/browser/actions/chatCodeblockActions.ts | Updates imports to use extracted reviewEdits module. |
| src/vs/sessions/contrib/chat/browser/nullInlineChatSessionService.ts | Updates to renamed IInlineChatSession interface. |
| extensions/copilot/src/extension/intents/node/allIntents.ts | Points Inline Chat intent registration at inlineChat2 implementation. |
| extensions/copilot/src/extension/inlineEdits/vscode-node/naturalLanguageHint.ts | Adds heuristic for detecting natural-language-dominated lines. |
| extensions/copilot/src/extension/inlineEdits/vscode-node/inlineCompletionProvider.ts | Switches to the new naturalLanguageHint location. |
| extensions/copilot/src/extension/inlineEdits/test/vscode-node/naturalLanguageHint.test.ts | Adds tests for the natural-language heuristic. |
| extensions/copilot/src/extension/inlineChat2/test/node/inlineChat2Prompt.spec.tsx | Fixes/adjusts imports for InlineChat2 prompt tests. |
| extensions/copilot/src/extension/inlineChat2/node/inlineChatPrompt.tsx | Adds InlineChat2 prompt rendering (currently with issues noted in review). |
| extensions/copilot/src/extension/inlineChat2/node/inlineChatIntent.ts | Minor refactor moving edit-tool allowlist into tool-calling helper. |
| extensions/copilot/src/extension/inlineChat/test/vscode-node/inlineChat.test.ts | Removes obsolete skipped E2E inline chat test. |
Copilot's findings
- Files reviewed: 18/21 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.