Accessibility: Add verbosity setting, keybinding, and aria hints for question carousel terminal focus#312429
Merged
meganrogge merged 4 commits intomainfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds accessibility improvements to the chat question carousel when it’s triggered by a terminal interaction, including a new verbosity setting, an Alt+T keybinding to focus the related terminal, and richer aria-label hints.
Changes:
- Add
accessibility.verbosity.chatQuestionCarouselto control whether navigation hints are appended to the carousel’s aria-label. - Introduce
workbench.action.chat.focusQuestionCarouselTerminalwithAlt+T, gated by a newchatQuestionCarouselHasTerminalcontext key. - Update the carousel UI to include keybinding-aware aria-label text and a
focusTerminal()pathway.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/actions/chatContextKeys.ts | Adds chatQuestionCarouselHasTerminal context key to gate terminal-focus affordances. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts | Adds focusQuestionCarouselTerminal() plumbing from input part to the active carousel. |
| src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts | Exposes focusQuestionCarouselTerminal() on ChatWidget for actions/keybindings. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts | Adds verbosity-driven aria hints, keybinding label injection, and terminal-focus support plus context key wiring. |
| src/vs/workbench/contrib/chat/browser/chat.ts | Extends IChatWidget with focusQuestionCarouselTerminal(). |
| src/vs/workbench/contrib/chat/browser/actions/chatActions.ts | Registers the new action + Alt+T keybinding with appropriate context gating. |
| src/vs/workbench/contrib/accessibility/browser/accessibilityConfiguration.ts | Adds the new verbosity setting to the accessibility configuration schema. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 2
…chatQuestionCarouselPart.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…chatQuestionCarouselPart.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
roblourens
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #312423
Adds accessibility improvements to the
askQuestionstool's question carousel when triggered by a terminal interaction:accessibility.verbosity.chatQuestionCarouselcontrols whether the carousel's aria label includes navigation hintsAlt+T(workbench.action.chat.focusQuestionCarouselTerminal) to focus the terminal from the carousel, gated by a newchatQuestionCarouselHasTerminalcontext key so it only activates when a terminal is present