Do not have pending title show up in session list title #312657
Merged
anthonykim1 merged 2 commits intomainfrom Apr 27, 2026
Merged
Do not have pending title show up in session list title #312657anthonykim1 merged 2 commits intomainfrom
anthonykim1 merged 2 commits intomainfrom
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent session titles (especially for Copilot CLI-backed sessions) from briefly switching to in-flight/request-derived text, keeping the Agents app session list title stable and consistent across refreshes and renames.
Changes:
- Adjust Copilot CLI session-title resolution to avoid using pending prompts for already-established sessions, and add a regression test.
- Update the Agents app Copilot sessions provider to prefer live chat-model custom titles and to keep locally-renamed titles stable across model refreshes.
- Add provider-level test coverage for “rename then refresh” behavior.
Show a summary per file
| File | Description |
|---|---|
src/vs/sessions/contrib/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts |
Expands test harness stubs and adds a regression test ensuring a renamed CLI title survives later session model refreshes. |
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts |
Adds title override plumbing (session/chat), display-title resolution via IChatService.getSession, and throttled cache refresh handling. |
extensions/copilot/src/extension/chatSessions/copilotcli/node/test/copilotCliSessionService.spec.ts |
Adds a regression test ensuring list labels don’t switch to pending prompt text for established sessions. |
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts |
Removes “pending prompt” from established-session title precedence and documents the intended behavior. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 4
3 tasks
justschen
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from: #311535 and #312038
Fixing issue where the session list title in the agents app temporarily changes in/out from original set title to per-request related content.
/cc @DonJayamanne @roblourens
Screen.Recording.2026-04-26.at.10.13.28.PM.mov
The session list was temporarily using the in-flight request text leading to undesirable UI.