Skip to content

Do not have pending title show up in session list title #312657

Merged
anthonykim1 merged 2 commits intomainfrom
anthonykim1/stablizeNamingInChatSessionAgent
Apr 27, 2026
Merged

Do not have pending title show up in session list title #312657
anthonykim1 merged 2 commits intomainfrom
anthonykim1/stablizeNamingInChatSessionAgent

Conversation

@anthonykim1
Copy link
Copy Markdown
Contributor

@anthonykim1 anthonykim1 commented Apr 27, 2026

Coming from: #311535 and #312038

Fixing issue where the session list title in the agents app temporarily changes in/out from original set title to per-request related content.
/cc @DonJayamanne @roblourens

Screen.Recording.2026-04-26.at.10.13.28.PM.mov

The session list was temporarily using the in-flight request text leading to undesirable UI.

Co-authored-by: Copilot <copilot@github.com>
@anthonykim1 anthonykim1 added this to the 1.118.0 milestone Apr 27, 2026
@anthonykim1 anthonykim1 self-assigned this Apr 27, 2026
Copilot AI review requested due to automatic review settings April 27, 2026 04:48
@anthonykim1 anthonykim1 changed the title working changes Do not have pending title show up in session list title Apr 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to prevent session titles (especially for Copilot CLI-backed sessions) from briefly switching to in-flight/request-derived text, keeping the Agents app session list title stable and consistent across refreshes and renames.

Changes:

  • Adjust Copilot CLI session-title resolution to avoid using pending prompts for already-established sessions, and add a regression test.
  • Update the Agents app Copilot sessions provider to prefer live chat-model custom titles and to keep locally-renamed titles stable across model refreshes.
  • Add provider-level test coverage for “rename then refresh” behavior.
Show a summary per file
File Description
src/vs/sessions/contrib/copilotChatSessions/test/browser/copilotChatSessionsProvider.test.ts Expands test harness stubs and adds a regression test ensuring a renamed CLI title survives later session model refreshes.
src/vs/sessions/contrib/copilotChatSessions/browser/copilotChatSessionsProvider.ts Adds title override plumbing (session/chat), display-title resolution via IChatService.getSession, and throttled cache refresh handling.
extensions/copilot/src/extension/chatSessions/copilotcli/node/test/copilotCliSessionService.spec.ts Adds a regression test ensuring list labels don’t switch to pending prompt text for established sessions.
extensions/copilot/src/extension/chatSessions/copilotcli/node/copilotcliSessionService.ts Removes “pending prompt” from established-session title precedence and documents the intended behavior.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 4

@anthonykim1 anthonykim1 merged commit 6c5bcb5 into main Apr 27, 2026
26 checks passed
@anthonykim1 anthonykim1 deleted the anthonykim1/stablizeNamingInChatSessionAgent branch April 27, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants