Skip to content

More complete getErrorCode#312776

Merged
alexr00 merged 2 commits intomainfrom
alexr00/damaged-wolf
Apr 27, 2026
Merged

More complete getErrorCode#312776
alexr00 merged 2 commits intomainfrom
alexr00/damaged-wolf

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Apr 27, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 27, 2026 14:32
@alexr00 alexr00 self-assigned this Apr 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Copilot’s GitHub integration error classification by expanding getErrorCode to derive a more descriptive string from an error’s name/message when other structured fields (status, GraphQL extensions code, etc.) are not present.

Changes:

  • Enhance getErrorCode to incorporate e.message and to special-case e.name === 'Error'.
  • Prefer returning a combined name: message string for non-generic error names.
Show a summary per file
File Description
extensions/copilot/src/platform/github/common/githubAPI.ts Adjusts error-code derivation logic used by GitHub-related telemetry/logging paths.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread extensions/copilot/src/platform/github/common/githubAPI.ts Outdated
@alexr00 alexr00 marked this pull request as ready for review April 27, 2026 14:47
@alexr00 alexr00 enabled auto-merge (squash) April 27, 2026 14:47
@alexr00 alexr00 merged commit 8a9656d into main Apr 27, 2026
26 checks passed
@alexr00 alexr00 deleted the alexr00/damaged-wolf branch April 27, 2026 16:09
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants