Agents - use etag when polling pull request information#312819
Merged
Agents - use etag when polling pull request information#312819
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds ETag-aware polling to the Agents GitHub integration so periodic refreshes of pull request data can leverage conditional requests (304 Not Modified) and reduce unnecessary rate-limit usage.
Changes:
- Introduce an ETag/statusCode-carrying response shape for GitHub REST requests and add an ETag-capable request path.
- Update the PR fetcher to use conditional requests and return wrapped responses (data + statusCode + etag).
- Update the PR model to persist ETags across polls and only update observables/mergeability when data changes.
Show a summary per file
| File | Description |
|---|---|
| src/vs/sessions/contrib/github/test/browser/githubFetchers.test.ts | Adjusts fetcher tests/mocks for the new response wrapper shape. |
| src/vs/sessions/contrib/github/browser/models/githubPullRequestModel.ts | Stores ETags and uses them during polling; updates mergeability computation to account for 304 responses. |
| src/vs/sessions/contrib/github/browser/githubApiClient.ts | Adds IGitHubApiResponse and an ETag-capable request variant that surfaces status code + ETag. |
| src/vs/sessions/contrib/github/browser/fetchers/githubPRFetcher.ts | Switches PR/reviews fetches to ETag-aware requests and returns wrapped responses with mapped data. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 4
Yoyokrazy
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.