Fix harness dropdown picker theming in AI Customizations editor#312867
Merged
joshspicer merged 1 commit intomainfrom Apr 27, 2026
Merged
Fix harness dropdown picker theming in AI Customizations editor#312867joshspicer merged 1 commit intomainfrom
joshspicer merged 1 commit intomainfrom
Conversation
The native <button> element was rendering with system 'buttonface' background, overriding the transparent background. Set appearance:none to disable native form control rendering, matching the pattern used by welcome-prompts-input. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a theming regression in the AI Customizations management editor where the harness dropdown <button> was showing Chromium’s native “buttonface” background instead of respecting the intended transparent styling.
Changes:
- Disable native button rendering for the harness dropdown via
-webkit-appearance: none; appearance: none;sobackground: transparentis honored. - Ensure the dropdown button inherits the workbench font via
font-family: inherit;.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/aiCustomization/media/aiCustomizationManagement.css |
Adjusts harness dropdown button styling to prevent native buttonface theming and inherit the editor font. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
dmitrivMS
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The harness dropdown in the Agent Customizations sidebar was rendering with a light system "buttonface" background instead of being transparent (regression introduced when
background: transparentwas added in #312689 — the transparent background was being overridden by Chromium's native<button>rendering).Setting
-webkit-appearance: none; appearance: none;disables the native form control rendering so the CSS background takes effect. Matches the pattern already used by.welcome-prompts-inputin this view.Also added
font-family: inherit;so the button uses the workbench font rather than the platform default.Before: light pill background as shown in the regression screenshot.
After: transparent background that picks up dropdown styling on hover.