Clean up some parameters and stuff in Claude#312946
Merged
TylerLeonhardt merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
Just some debt.
vijayupadya
previously approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Claude chat session plumbing to simplify method signatures/constructor parameters and move more per-request setup (e.g., prompt resolution, server config lookup) into ClaudeCodeSession, with corresponding test updates.
Changes:
- Simplifies
ClaudeAgentManager.handleRequestandClaudeCodeSessionconstruction by removing redundant parameters and reading model/permission state from the session state service at invocation time. - Moves prompt block resolution into the session’s request-processing loop and fetches language-model-server config from
ClaudeLanguageModelServer.getConfig()when starting the SDK session. - Updates Claude unit tests to match the new APIs and mocks (including adding
getConfig()to the mock language model server).
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSessionContentProvider.ts | Updates the handleRequest call site to match the simplified signature. |
| extensions/copilot/src/extension/chatSessions/claude/node/claudeCodeAgent.ts | Refactors manager/session APIs and internal request queueing; shifts config/prompt resolution responsibilities into ClaudeCodeSession. |
| extensions/copilot/src/extension/chatSessions/claude/node/test/claudeCodeAgentOTel.spec.ts | Updates OTel tests for new ClaudeCodeSession constructor/invoke signatures and server mock shape. |
| extensions/copilot/src/extension/chatSessions/claude/node/test/claudeCodeAgent.spec.ts | Updates core agent/session tests for new signatures and removes obsolete expectations. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
Contributor
blocks-ci screenshots changedReplace the contents of Updated blocks-ci-screenshots.md<!-- auto-generated by CI — do not edit manually -->
#### editor/codeEditor/CodeEditor/Dark
#### editor/codeEditor/CodeEditor/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidget/Light
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Dark
#### editor/inlineChatZoneWidget/InlineChatZoneWidgetTerminated/Light
 |
justschen
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some debt.