Fix issue with hover reappearing on Esc, Alt-tab, link click etc.#313117
Merged
Fix issue with hover reappearing on Esc, Alt-tab, link click etc.#313117
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent managed hovers from immediately reappearing after they were dismissed (e.g. via Esc, window deactivation/Alt-tab, clicking within the hover), by adding additional guards in the managed-hover focus handler and covering the behavior with new unit tests.
Changes:
- Add focus-event guards in
HoverService.setupManagedHoverto avoid re-triggering a hover when focus returns from a dismissed hover or from window reactivation. - Add new
HoverServicetests asserting that dismissed hovers don’t re-show on subsequent focus events under specificrelatedTargetconditions.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/hover/browser/hoverService.ts |
Adds early-return conditions in the managed-hover onFocus handler to avoid re-showing hovers after dismissal/focus transitions. |
src/vs/platform/hover/test/browser/hoverService.test.ts |
Adds regression tests for focus-driven hover reappearance after dismissal. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
justschen
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce: