Skip to content

fix updating active harness wrt customizations#313289

Merged
joshspicer merged 1 commit intomainfrom
agents/when-inside-a-session-we-do-a-great-f7670de0
Apr 29, 2026
Merged

fix updating active harness wrt customizations#313289
joshspicer merged 1 commit intomainfrom
agents/when-inside-a-session-we-do-a-great-f7670de0

Conversation

@joshspicer
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings April 29, 2026 18:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR ensures the Sessions window keeps the active AI customization “harness” aligned with the currently active session type, so the Customizations sidebar/editor reflect the correct session context even when harnesses register asynchronously.

Changes:

  • Add a new workbench contribution that observes activeSession.sessionType and updates ICustomizationHarnessService’s active harness when a matching harness is available.
  • Re-run the sync when availableHarnesses changes to handle late external harness registration (e.g. agent host / CLI).
Show a summary per file
File Description
src/vs/sessions/contrib/sessions/browser/customizationsToolbar.contribution.ts Registers a new ActiveSessionHarnessSyncContribution that keeps the customization harness in sync with the active session’s sessionType.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@joshspicer joshspicer marked this pull request as ready for review April 29, 2026 18:54
Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tests or docs?

@joshspicer joshspicer merged commit de1f8b1 into main Apr 29, 2026
30 checks passed
@joshspicer joshspicer deleted the agents/when-inside-a-session-we-do-a-great-f7670de0 branch April 29, 2026 19:53
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants