Skip to content

Bring back update.titleBar setting, hide Update indicator while debugging#313549

Merged
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/update-toolbar-setting
Apr 30, 2026
Merged

Bring back update.titleBar setting, hide Update indicator while debugging#313549
dmitrivMS merged 1 commit intomainfrom
dev/dmitriv/update-toolbar-setting

Conversation

@dmitrivMS
Copy link
Copy Markdown
Contributor

@dmitrivMS dmitrivMS commented Apr 30, 2026

Fixes #311929
Fixes #302497

…ging

Co-authored-by: Copilot <copilot@github.com>
Copilot AI review requested due to automatic review settings April 30, 2026 17:46
@dmitrivMS dmitrivMS added the install-update VS Code installation and upgrade system issues label Apr 30, 2026
@dmitrivMS dmitrivMS self-assigned this Apr 30, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reintroduces a user-facing setting to control whether the update indicator appears in the title bar, and suppresses the indicator while the debugger is active to reduce UI clutter/conflicts.

Changes:

  • Add update.titleBar configuration (application scope, non-web) to control visibility of the update indicator.
  • Update the title bar update indicator contribution to respect update.titleBar dynamically (and react to configuration changes).
  • Hide the update indicator action while inDebugMode is true.
Show a summary per file
File Description
src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts Adds config-driven gating for the update title bar indicator and hides it during debug sessions.
src/vs/platform/update/common/update.config.contribution.ts Re-adds the update.titleBar setting to the update configuration schema.

Copilot's findings

  • Files reviewed: 2/2 changed files
  • Comments generated: 1

Comment thread src/vs/workbench/contrib/update/browser/updateTitleBarEntry.ts
@dmitrivMS dmitrivMS marked this pull request as ready for review April 30, 2026 18:55
@dmitrivMS dmitrivMS enabled auto-merge (squash) April 30, 2026 18:55
@dmitrivMS dmitrivMS merged commit 753d67d into main Apr 30, 2026
30 checks passed
@dmitrivMS dmitrivMS deleted the dev/dmitriv/update-toolbar-setting branch April 30, 2026 19:01
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

install-update VS Code installation and upgrade system issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Obnoxious window header Update button can not be disabled Who's idea was to add big ass update button near search bar?

3 participants