Skip to content

claude sessions endpoint cleanup#313685

Merged
justschen merged 1 commit into
mainfrom
justin/yveltal
May 1, 2026
Merged

claude sessions endpoint cleanup#313685
justschen merged 1 commit into
mainfrom
justin/yveltal

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

cleans up useless try/catch

Copilot AI review requested due to automatic review settings May 1, 2026 07:53
@justschen justschen enabled auto-merge (squash) May 1, 2026 07:53
@justschen justschen requested a review from TylerLeonhardt May 1, 2026 07:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies the Claude sessions endpoint resolution path by removing a redundant wrapper that caught errors which are already handled inside the Claude models service.

Changes:

  • Removes the _resolveEndpointForRequest helper and its try/catch wrapper.
  • Calls claudeModels.resolveEndpoint(...) directly from request handling and session content building.
  • Drops the now-unused IChatEndpoint import.
Show a summary per file
File Description
extensions/copilot/src/extension/chatSessions/vscode-node/claudeChatSessionContentProvider.ts Removes redundant endpoint-resolution wrapper and uses claudeModels.resolveEndpoint directly.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0

@justschen justschen merged commit 3a126b5 into main May 1, 2026
30 checks passed
@justschen justschen deleted the justin/yveltal branch May 1, 2026 13:57
@vs-code-engineering vs-code-engineering Bot added this to the 1.119.0 milestone May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants