Fix TreeError in AgentSessionsView#314067
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Agent Sessions view’s “reveal session” behavior against transient tree model inconsistencies that can occur during async refresh, preventing unhandled tree errors when trying to scroll a session into view (#309891).
Changes:
- Wraps the tree visibility check (
getRelativeTop) and reveal call in atry/catchto avoid propagating tree-model exceptions. - Returns
falseif the tree operation fails during refresh, instead of throwing.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts | Adds error handling around tree reveal logic to avoid unhandled errors during async refresh. |
Copilot's findings
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/agentSessions/agentSessionsControl.ts:850
setFocus/setSelectioncan also throwTreeErrorif the tree model changes betweenhasNode(session)and these calls (they resolve nodes/list indexes internally). To fully prevent the unhandled TreeError, consider moving these calls inside the same try/catch (or guarding similarly) so transient refresh races don't still crash.
this.sessionsList.setFocus([session]);
this.sessionsList.setSelection([session]);
- Files reviewed: 1/1 changed files
- Comments generated: 1
jrieken
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated Description:Catch potential errors when revealing a session in the Agent Sessions view to handle cases where the tree model may be temporarily inconsistent during async refresh. This change prevents unhandled errors from occurring when attempting to access the relative position of a session.Fixes #309891