Skip to content

add ChatSkill.disableModelInvocation#314174

Merged
aeschli merged 3 commits into
mainfrom
aeschli/biological-sturgeon-760
May 4, 2026
Merged

add ChatSkill.disableModelInvocation#314174
aeschli merged 3 commits into
mainfrom
aeschli/biological-sturgeon-760

Conversation

@aeschli
Copy link
Copy Markdown
Contributor

@aeschli aeschli commented May 4, 2026

No description provided.

Copilot AI review requested due to automatic review settings May 4, 2026 18:06
@aeschli aeschli enabled auto-merge (squash) May 4, 2026 18:06
@aeschli aeschli self-assigned this May 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new disableModelInvocation flag to vscode.ChatSkill in the chatPromptFiles proposed API and wires it through the main-thread/ext-host DTOs so extensions can observe whether a skill should be excluded from automatic model invocation.

Changes:

  • Extend ChatSkill proposed API shape with disableModelInvocation.
  • Plumb disableModelInvocation through ISkillDto and the mainThread/extHost conversion layers.
  • Update one Copilot extension test stub to include the new property.
Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatPromptFiles.d.ts Adds ChatSkill.disableModelInvocation to the proposed API surface.
src/vs/workbench/api/common/extHostChatAgents2.ts Maps disableModelInvocation from DTOs into vscode.ChatSkill objects.
src/vs/workbench/api/common/extHost.protocol.ts Extends ISkillDto with disableModelInvocation.
src/vs/workbench/api/browser/mainThreadChatAgents2.ts Includes disableModelInvocation when serializing skills to DTOs.
extensions/copilot/src/extension/chatSessions/vscode-node/test/claudeCustomizationProvider.spec.ts Updates a ChatSkill test stub to include the new required field.

Copilot's findings

  • Files reviewed: 4/5 changed files
  • Comments generated: 0

Copilot stopped work on behalf of aeschli due to an error May 4, 2026 20:31
@aeschli aeschli merged commit 2358983 into main May 4, 2026
26 of 28 checks passed
@aeschli aeschli deleted the aeschli/biological-sturgeon-760 branch May 4, 2026 20:44
@vs-code-engineering vs-code-engineering Bot added this to the 1.120.0 milestone May 4, 2026
@aeschli
Copy link
Copy Markdown
Contributor Author

aeschli commented May 4, 2026

@copilot now lets create ComputeAutomaticInstructions in the extension as outlined in the plan (step ). Do not yet remove the old call sites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants