Announce section counts in AI Customization sidebar for screen readers#314253
Merged
Conversation
Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/28d27915-a2f9-4fd2-9baf-a206ca6eb558 Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix VoiceOver not announcing the count
Announce section counts in AI Customization sidebar for screen readers
May 4, 2026
meganrogge
approved these changes
May 4, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves screen reader announcements for AI Customization section counts by ensuring the counts are included in the accessible name (rather than being rendered as separate sibling DOM nodes that VoiceOver ignores).
Changes:
- Updated the management editor sections list to include count information in each row’s ARIA label when
count > 0. - Updated the Sessions AI Customization overview to keep per-section
aria-labelsynchronized with asynchronously-updated counts, using localized strings.
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationManagementEditor.ts | Adds localized ARIA labels that include section counts in the management editor’s sections list. |
| src/vs/sessions/contrib/aiCustomizationTreeView/browser/aiCustomizationOverviewView.ts | Keeps overview section aria-labels updated as counts resolve asynchronously (via a stored element map + helper). |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 2
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
meganrogge
approved these changes
May 4, 2026
Contributor
Screenshot ChangesBase: Changed (7)Errored (18)Fixtures that failed to render — no screenshot was produced.
|
dmitrivMS
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The count badges next to the AI Customization sections (e.g. "Agents 9", "Skills 28") were rendered as sibling DOM nodes outside the focusable item's accessible name, so VoiceOver only announced the section label.
Changes
AICustomizationManagementEditor— Sections listaccessibilityProvider.getAriaLabelnow returns"{label}, {count} items"whencount > 0. The existingupdateSectionCountre-splice path refreshes the aria-label automatically.AICustomizationOverviewView— The per-sectionaria-labelwas set once at render time with the initial0count and used a non-localized string. Added asectionElementsmap and agetSectionAriaLabelhelper soupdateCountElements()keeps the aria-label in sync as counts resolve asynchronously, using a localized format.